Modernize plugin for Gradle 9.x and AGP 8.x compatibility #42
Conversation
This PR updates the project-replicator plugin to work with modern
Gradle and Android Gradle Plugin versions.
Changes:
1. **AndroidCollector.kt**: Replace internal `BasePlugin` class usage
with public plugin ID checks. The `BasePlugin` class from
`com.android.build.gradle.internal.plugins` was an internal API
that has been removed/changed in AGP 8.x.
2. **GatherModuleInfoTask.kt**:
- Replace deprecated `JavaPluginConvention` with `JavaPluginExtension`
(Convention API was removed in Gradle 9)
- Replace `ProjectDependency.dependencyProject.path` with path
reconstruction from group/name (dependencyProject was removed in
Gradle 9)
3. **ResourceDataGathering.kt**: Replace AGP's internal `XmlUtils`
class with standard Java SAX parser configuration. The
`com.android.utils.XmlUtils` class was an internal utility that
is no longer reliably available.
4. **Versions.kt**: Update AGP version to 8.3.0 and Kotlin to 1.7.20
for compilation compatibility.
These changes were tested against a large Android project (1,337
modules) running Gradle 9.1.0 and AGP 8.13.2.
Co-Authored-By: Claude <[email protected]>
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Summary of ChangesHello @kaeawc, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly modernizes the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request effectively modernizes the plugin for compatibility with Gradle 9.x and AGP 8.x. The changes correctly replace usages of internal or deprecated APIs with their modern, public equivalents, which significantly improves the plugin's robustness and future-proofing. The approach to replace BasePlugin with plugin ID checks and JavaPluginConvention with JavaPluginExtension is well-executed. I have a couple of suggestions to improve code clarity and robustness in exception handling.
| val projectPath = if (group != null && group != name) { | ||
| // Extract path from group by converting dots to colons and removing root project name | ||
| val pathFromGroup = group.substringAfter('.', "").replace('.', ':') | ||
| if (pathFromGroup.isNotEmpty()) { | ||
| ":$pathFromGroup:$name" | ||
| } else { | ||
| ":$name" | ||
| } | ||
| } else { | ||
| ":$name" | ||
| } |
There was a problem hiding this comment.
This logic for reconstructing the project path is a bit complex and contains some redundant code due to the nested if-else structure and repeated else blocks. It can be refactored to be more linear and easier to read, which will improve maintainability.
val projectPath = (if (group != null && group != name) {
// Extract path from group by converting dots to colons and removing root project name
group.substringAfter('.', "").replace('.', ':')
} else {
""
}).let { pathFromGroup ->
if (pathFromGroup.isNotEmpty()) {
":$pathFromGroup:$name"
} else {
":$name"
}
}| } catch (e: Exception) { | ||
| // Ignore if features not supported | ||
| } |
There was a problem hiding this comment.
Catching a generic Exception and silently ignoring it can hide potential configuration issues. While the intention is to ignore unsupported features, this could also swallow other unexpected errors. It would be better to log the exception to provide visibility into any problems during SAX parser configuration, especially since this is security-related configuration.
} catch (e: Exception) {
// Ignore if features not supported, but log a warning.
println("Warning: Failed to set security features on SAX parser: ${e.message}")
}1 participant
Summary
This PR updates the project-replicator plugin to work with modern Gradle (9.x) and Android Gradle Plugin (8.x) versions.
Changes
AndroidCollector.kt: Replace internal
BasePluginclass usage with public plugin ID checksBasePluginclass fromcom.android.build.gradle.internal.pluginswas an internal API that has been removed/changed in AGP 8.xGatherModuleInfoTask.kt:
JavaPluginConventionwithJavaPluginExtension(Convention API was removed in Gradle 9)ProjectDependency.dependencyProject.pathwith path reconstruction from group/name (dependencyProjectwas removed in Gradle 9)ResourceDataGathering.kt: Replace AGP's internal
XmlUtilsclass with standard Java SAX parser configurationcom.android.utils.XmlUtilsclass was an internal utility that is no longer reliably availableVersions.kt: Update AGP version to 8.3.0 and Kotlin to 1.7.20 for compilation compatibility
Test plan
Notes
The project path reconstruction for
ProjectDependencyuses the group/name convention where the group contains dot-separated path segments. This handles the common case where project groups follow the patternrootProject.subpath.module.🤖 Generated with Claude Code